allow away and back to be collapsed #4669
Merged
+24
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunnre8
force-pushed
the
collapseAway
branch
from
1b0de06 to
9340994
Compare
MaxLeiter
reviewed
Dec 29, 2022
MaxLeiter
reviewed
Dec 29, 2022
This means we also apply the collapsing to normal queries, which might also collapse other things like joins / quits which may be undesired by some Fixes: #4583
brunnre8
force-pushed
the
collapseAway
branch
from
9340994 to
e597e75
Compare
|
flipped to marked away once in the singular case, as marked away 1 time sounds wrong to me. |
brunnre8
added
Type: Feature
MaxLeiter
approved these changes
Jan 20, 2023
MaxLeiter
removed
the
Status: needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we also apply the collapsing to normal queries, which might also collapse other things like joins / quits which may be undesired by some