Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Morning theme nick colors #4690

Merged
merged 1 commit into from
Feb 5, 2023

Conversation

maxpoulin64
Copy link
Member

PR #4649 introduced a regression on the Morning theme as the #chat.colored-nicks CSS selector was removed from Default but not Morning. The result is that Morning no longer had nick colors. This applies the same change that was applied to the global CSS.

Verified

This commit was signed with the committer’s verified signature.
andrewlock Andrew Lock
PR thelounge#4649 introduced a regression on the Morning theme as the `#chat.colored-nicks` CSS selector was removed from Default but not Morning. The result is that Morning no longer had nick colors.
@brunnre8
Copy link
Member

brunnre8 commented Feb 5, 2023

whoops, sorry.

Thanks for catching that.

@MaxLeiter MaxLeiter merged commit 0036696 into thelounge:master Feb 5, 2023
@maxpoulin64 maxpoulin64 deleted the fix-morning-colors branch February 6, 2023 03:52
@MaxLeiter MaxLeiter added this to the Next milestone Feb 14, 2023
@MaxLeiter MaxLeiter added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants