use createReadStream: apollographql/apollo-server#2105

thematters · Mar 29, 2019 · 8ca9d9a · 8ca9d9a
1 parent d3e4feb
commit 8ca9d9a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/src/connectors/aws/index.ts b/src/connectors/aws/index.ts
@@ -76,8 +76,15 @@ export class AWSService {
    * Upload file to AWS S3.
    */
   baseUploadFile = async (folder: GQLAssetType, file: any): Promise<string> => {
-    const { stream, mimetype, encoding } = file
-    const filename = slugify(file.filename)
+    const {
+      createReadStream,
+      mimetype,
+      encoding,
+      filename: filenameOrigin
+    } = await file
+    const stream = createReadStream()
+
+    const filename = slugify(filenameOrigin)
     const key = `${folder}/${v4()}/${filename}`
     const result = await this.s3
       .upload({

diff --git a/src/mutations/system/singleFileUpload.ts b/src/mutations/system/singleFileUpload.ts
@@ -8,13 +8,7 @@ const resolver: MutationToSingleFileUploadResolver = async (
   { input: { type, file } },
   { viewer, dataSources: { systemService } }
 ) => {
-  // if (!viewer.id) {
-  //   throw new AuthenticationError('visitor has no permission')
-  // }
-
-  const data = await file
-  const { filename, mimetype, encoding } = data
-  const key = await systemService.aws.baseUploadFile(type, data)
+  const key = await systemService.aws.baseUploadFile(type, file)
   const asset: ItemData = {
     uuid: v4(),
     authorId: viewer.id,