Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix/springfox-issue #291

Merged
merged 4 commits into from
Jan 18, 2023
Merged

hotfix/springfox-issue #291

merged 4 commits into from
Jan 18, 2023

Conversation

jyeonjyan
Copy link
Member

작업내용

  • springfox library의 잔존(?)이슈 해결
    • location 과 관련없이 같은 이름의 클래스가 project에 공존할 때 @RequestBody 대상(클래스)을 정확히 발견하지 못함.
  • 누락된 validation field 추가
  • endDate 에 대해 not null data -> nullable data 로 변경함.

@jyeonjyan jyeonjyan added documentation Improvements or additions to documentation hotfix labels Jan 16, 2023
@jyeonjyan jyeonjyan requested a review from siwony January 16, 2023 09:07
@jyeonjyan jyeonjyan self-assigned this Jan 16, 2023
@github-actions
Copy link

Unit Test Results

32 tests  ±0   23 ✔️ ±0   16s ⏱️ +3s
17 suites ±0     9 💤 ±0 
17 files   ±0     0 ❌ ±0 

Results for commit 5117260. ± Comparison against base commit efc28fd.

jeongcoool
jeongcoool approved these changes Jan 16, 2023
View reviewed changes
Copy link

@jeongcoool jeongcoool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

siwony
siwony approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@siwony siwony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@hyeongrok7874
Copy link
Member

@jyeonjyan님 요청으로 대신해서 merge 하겠습니다.

@hyeongrok7874 hyeongrok7874 merged commit 9610fa4 into develop Jan 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the hotfix/springfox-issue branch January 18, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siwony siwony siwony approved these changes

@jeongcoool jeongcoool jeongcoool approved these changes

Assignees

@jyeonjyan jyeonjyan

Labels
documentation Improvements or additions to documentation hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jyeonjyan @hyeongrok7874 @siwony @jeongcoool