Various SIMBLtweak fixes (installation, uninstallation, etc.) #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed up uninstall command to not break when encountering spaces in file paths (and silenced the `rm -d` output).
Updated default install path to MacForge's plugin directory. This retires mySIMBL support in favour of MacForge.
Frameworks go in ./Frameworks in the project root. When initially compiled, the link paths for the frameworks in the tweak binary will be incorrect: they'll use `@rpath`, which will evaluate to the wrong path when injected into a third-party app. To correct this, we remove the `@rpath` bit of the link path then prepend the installation path of the tweak bundle.
jacobcxdev
changed the title
make do, make install and make uninstall.
uroboro
approved these changes
Oct 9, 2020
kabiroberai
requested changes
Oct 9, 2020
There was a problem hiding this comment.
I can't comment on the rest of the PR (although I assume @uroboro's approval means it's alright), but the rpath hackiness should definitely be looked into more before this is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #516, as requested by @kirb.