Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update two references to non-existent vars #688

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

L1ghtmann
Copy link
Member

What does this implement/fix? Explain your changes.

  • Updates legacy.mk to no longer attempt to assign FW_PACKAGE_FILENAME to THEOS_PACKAGE_FILENAME, as the latter no longer exists.
    • Will now check for FW_PACKAGE_FILENAME's existence and warn about its deprecation and Theos' automatic handling of the package filename.
  • Updates references to SDKTARGET in Windows' iphone.mk to _THEOS_TARGET_SDK_BIN_PREFIX.
  • Adds previously missing _THEOS_TARGET_USE_CLANG_TARGET_FLAG to Windows' iphone.mk.

Does this close any currently open issues?

N/A

Any relevant logs, error output, etc?

N/A

Any other comments?

The Windows iphone.mk changes are just for completeness since support for that platform is currently considered deprecated. Said changes have not been tested, but it now lines up with Linux's iphone.mk.

Where has this been tested?

Operating System:

Linux (WSL)

Platform:

Target Platform:

Toolchain Version:

SDK Version:

makefiles/legacy.mk Outdated Show resolved Hide resolved
Copy link

@corywhirl06 corywhirl06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants