Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .keep for lib/iphone/rootless #725

Merged
merged 3 commits into from May 20, 2024
Merged

Conversation

MrGcGamer
Copy link
Contributor

What does this implement/fix? Explain your changes.

This is just GitHub house-keeping $THEOS/lib/iphone/rootless already exists, after installation

Does this close any currently open issues?

Don't think so

Any relevant logs, error output, etc?

Any other comments?

Where has this been tested?

Operating System:

Platform:

Target Platform:

Toolchain Version:

SDK Version:

@MrGcGamer
Copy link
Contributor Author

included in #712

@MrGcGamer MrGcGamer closed this Apr 17, 2023
@MrGcGamer
Copy link
Contributor Author

As #712 has been closed, without implementing this, I am reopening this PR.

Copy link
Member

@leptos-null leptos-null left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit-pick for consistency with other .keep files in this repo.

This PR is important for internal-library-stage_/internal-framework-stage_ to work correctly.

Copy link
Member

@leptos-null leptos-null left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@leptos-null
Copy link
Member

#801 now creates this directory as needed.
I'm merging this PR as well so that the directory is easy to access.
Any number of schemes may exist, so I'm planning to include (via .keep files) lib/{target}/{scheme} directories in this repositories that have a mirrored directory in https://github.com/theos/lib

@leptos-null leptos-null merged commit d8f0527 into theos:master May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants