Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mimic frameworks by installing libraries to THEOS_LIBRARY_PATH in internal stage #748

Merged
merged 2 commits into from May 16, 2024
Merged

Mimic frameworks by installing libraries to THEOS_LIBRARY_PATH in internal stage #748

merged 2 commits into from May 16, 2024

Conversation

L1ghtmann
Copy link
Member

@L1ghtmann L1ghtmann commented Jul 8, 2023 •
edited

What does this implement/fix? Explain your changes.

See title

Does this close any currently open issues?

I don't think so

Any relevant logs, error output, etc?

Any other comments?

  • Figured this was worth implementing officially as most devs implement their own internal-/after-stage to do just this
  • The logic feels a bit messy, so if there is any way to simplify it I'm all ears!

Where has this been tested?

Operating System: …

Linux (WSL)

Platform: …

Target Platform: …

Toolchain Version: …

SDK Version: …

@L1ghtmann L1ghtmann mentioned this pull request Oct 14, 2023
Merged
leptos-null
leptos-null approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@leptos-null leptos-null left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good (mirrors framework code).
Tested default and rootless, worked well.

@leptos-null leptos-null merged commit afd74e5 into theos:master May 16, 2024
@L1ghtmann L1ghtmann deleted the lib-stage-install branch May 16, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uroboro uroboro uroboro approved these changes

@leptos-null leptos-null leptos-null approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@L1ghtmann @uroboro @leptos-null