Fully supports progressive JPGS and Interlaced images for 3.x #394
Conversation
|
TODO:
|
|
@ADmad would you mind to take a look and tell me what you think? I'm not sure if introducing this new encoding strategy would be the best for this package. feedbacks are welcome :) |
|
Sorry I haven't had the time to look into this but could you please address the failing tests in the meantime. |
|
@ADmad I addressed all the issues that Github Actions was issuing. Before setting this ready for review, could you point me the best place where I could add the tests for the progressive/interlaced images I am introducing? |
|
@ADmad I added some comments to help the review process. Ideally, it would be good to add tests for the new option added to the image API. But I don't have idea what would be the best place to put it. |
src/Manipulators/Encode.php
Outdated
| break; | ||
| case 'gif': | ||
| case 'png': | ||
| $encoderOptions['interlaced'] = $shouldInterlace; |
There was a problem hiding this comment.
Quality option isn't used for png/gif?
There was a problem hiding this comment.
Unfortunately, there is no such option anymore.
- https://github.com/Intervention/image/blob/develop/src/Encoders/GifEncoder.php#L11
- https://github.com/Intervention/image/blob/develop/src/Encoders/PngEncoder.php#L11
Options are pretty limited in this new version.
|
@ADmad I applied the suggested changes and also add a new doc entry for the new option. I'm just not sure how to preview documentation locally, but I guess it is following the same convention used before. Also, do you have idea on how we could test this new feature? I just updated |
The intent of this PR is to introduce support to generate progressive JPEGs or interlaced images.
Couple days ago, the author of Intervention provided support to accomplish that https://github.com/Intervention/image/releases/tag/3.6.0
With that, I did some adjustments on Glide API to get the desired support.
Highlights:
Encodemanipulator moved from the$manipulatorslist, because it needs to be the last manipulator to run when generating the images.Encodemanipulator now returns aEncodedImage. This change avoids to double encode image when generating it.Encodealso makes more use of Interventionenumsto encode the image properly.