feat: use own argument parser to replace structopt
#60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
structopt has been replaced by clap, whose dependency libc does not build on newer architectures (e.g., loongarch64). My previous attempts to port choose to clap v4 resulted in an incompatible change in allow_hyphen_values's behavior - I have reported this issue to the upstream: - clap-rs/clap#5434 - clap-rs/clap#4187 To simplify things, I wrote my own argument parser for clap.. This change passes `cargo test` .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
structopthas been replaced byclap,whose dependency
libcdoes not build on newer architectures (e.g.,loongarch64). My previous attempts to port choose toclap v4resulted in an incompatible change in allow_hyphen_values's behavior - I have reported this issue to the upstream:allow_hyphen_valuesclap-rs/clap#4187To simplify things, I wrote my own argument parser..
This change passes
cargo test.