Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve find_github_artifact role #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jvasseur
Copy link
Member

@jvasseur jvasseur commented Apr 3, 2024

  • Add check_mode: false to GET request to allow running the role in check mode.
  • Remplace workflow_name parameter with workflow_file :
    • The old name could be confused with the name attribute in the workflow file.
    • If you use the yml extension you couldn't target the workflow file (but why would you do that unless you where on windows 3.1)
  • Resolve download redirection before passing the URL to the next role.

@jvasseur jvasseur force-pushed the improve-find-github-artifact branch from 66f779b to 9b065ab Compare April 3, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant