Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rollup v4 #56

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Support Rollup v4 #56

merged 1 commit into from
Nov 1, 2023

Conversation

sockmaster27
Copy link
Contributor

Tests seem to be passing, and I'm not seeing anything immediately relevant in the release notes.

@pioug
Copy link
Collaborator

pioug commented Nov 1, 2023

I've published a fork in the meantime: https://www.npmjs.com/package/@pioug/rollup-plugin-css-only. It should be almost like a drop-in replacement.

"rollup-plugin-css-only": "npm:@pioug/rollup-plugin-css-only@^5.0.0",

For reference, the equivalent changes for rollup-plugin-import-css (jleeson/rollup-plugin-import-css#18) have been merged too.

@thgh, I can help maintain this plugin, at least by handling the chores, if you accept. I use it at work, so I don't mind spending time on it.

@thgh
Copy link
Owner

thgh commented Nov 1, 2023

Hi @pioug what can I do to help you maintain this plugin?

I have invited you to the repo, feel free to resolve/merge where needed. Consider keeping changes small (or add tests).

Also consider if this plugin could be moved to the @rollup/plugins repo.

@thgh thgh merged commit 29cf9c7 into thgh:v4 Nov 1, 2023
0 of 4 checks passed
@thgh
Copy link
Owner

thgh commented Nov 1, 2023

Published in v4.4

@pioug
Copy link
Collaborator

pioug commented Nov 2, 2023

Thank you so much, @thgh, for the invitation 🙏

I think one thing that may be helpful too is having publishing rights on npm (my account: https://www.npmjs.com/~pioug) 💦 Like here, for example, I think the v4.4 is not published yet?

Also, consider if this plugin could be moved to the @rollup/plugins repository.

That sounds even better and sustainable!

@thgh
Copy link
Owner

thgh commented Nov 2, 2023

Oops, it errored, published for real now! https://www.npmjs.com/package/rollup-plugin-css-only

I'm ok transfering publishing rights, but security wise I would like to wait for a while and build some trust first. (most people volunteering to maintain and getting repo access end up not maintaining after all, so would rather limit the blast radius)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants