Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @rollup/plugin-buble #57

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Remove @rollup/plugin-buble #57

merged 1 commit into from
Nov 2, 2023

Conversation

pioug
Copy link
Collaborator

@pioug pioug commented Nov 2, 2023

I've never heard about Buble before 馃挦 but it looks like we don't need it for this package.

Bubl茅 was created when ES2015 was still the future. Nowadays, all modern browsers support all of ES2015 and (in some cases) beyond. Unless you need to support IE11, you probably don't need to use Bubl茅 to convert your code to ES5.

@pioug pioug requested a review from thgh November 2, 2023 11:02
thgh
thgh approved these changes Nov 2, 2023
View reviewed changes
Copy link
Owner

@thgh thgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe, buble, another Rich Harris project 馃槅

@thgh thgh merged commit 6606200 into v4 Nov 2, 2023
2 checks passed
@pioug pioug deleted the remove-buble branch November 2, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thgh thgh thgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pioug @thgh