Fix wrong roles comparison

thlbaut · Mar 3, 2020 · 3d9ef9b · 3d9ef9b
1 parent d246e94
commit 3d9ef9b
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php b/src/Symfony/Component/Security/Core/Authentication/Token/AbstractToken.php
@@ -316,14 +316,15 @@ private function hasUserChanged(UserInterface $user): bool
         if ($this->user->getSalt() !== $user->getSalt()) {
             return true;
         }
-
+
+        $currentUserRoles = array_map('strval', (array) $this->user->getRoles());
         $userRoles = array_map('strval', (array) $user->getRoles());
 
         if ($this instanceof SwitchUserToken) {
             $userRoles[] = 'ROLE_PREVIOUS_ADMIN';
         }
 
-        if (\count($userRoles) !== \count($this->getRoleNames()) || \count($userRoles) !== \count(array_intersect($userRoles, $this->getRoleNames()))) {
+        if (\count($userRoles) !== \count($currentUserRoles) || \count($userRoles) !== \count(array_intersect($userRoles, $currentUserRoles))) {
             return true;
         }