Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkg): fix main file #5

Merged
merged 1 commit into from May 14, 2021
Merged

Conversation

Kocal
Copy link
Contributor

@Kocal Kocal commented Oct 7, 2018

There is no find-parent-dir.js file in this package, only a index.js.
This fix this error when using Yarn Plug'n'play:

Error: Couldn't find a suitable Node resolution for unqualified path "/home/kocal/.cache/yarn/v3/npm-find-parent-dir-0.3.0-33c44b429ab2b2f0646299c5f9f718f376ff8d54/node_modules/find-parent-dir"

@arcanis
Copy link

arcanis commented Dec 5, 2018

Note that this issue is fixed in Yarn master (yarnpkg/yarn#6682), and will be part of the 1.13 🙂

Still should be fixed in this package, though!

@Kocal
Copy link
Contributor Author

Kocal commented Dec 5, 2018

Oh nice, I wasn't aware of your PR, thanks! 🙂

@dorian-marchal
Copy link

Ah marrant @Kocal, le monde est petit 😄 . J'avais pas vu ta PR, du coup j'ai fait la mienne : #6

Je la ferme, du coup.

@Kocal
Copy link
Contributor Author

Kocal commented Apr 16, 2019

Marrant de te voir ici ! 😋

@smorimoto
Copy link

@thlorenz Could you check this?

@Niek
Copy link

Niek commented May 14, 2021

I emailed @thlorenz asking to merge this.

@thlorenz thlorenz merged commit 755a3ab into thlorenz:master May 14, 2021
@thlorenz
Copy link
Owner

Sorry for letting this linger .. I got way too many github notifications going on :)

@thlorenz
Copy link
Owner

Published a patch to v0.3.1.

@Kocal
Copy link
Contributor Author

Kocal commented May 14, 2021

Nice!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants