Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/use tahu for sparkplug decoding #794

Merged
merged 5 commits into from
May 24, 2024

Conversation

bj00rn
Copy link
Collaborator

@bj00rn bj00rn commented May 17, 2024

Use tahu https://github.com/eclipse/tahu for sparkplug

Based on #793

Changes

@thomasnordquist thoughts on this?, Why roll our own decoding, but maybe you have been down this road before?

@bj00rn bj00rn force-pushed the feat/use-tahu-for-sparkplug-decoding branch from b03cd3c to f4bda3e Compare May 17, 2024 14:14
@thomasnordquist
Copy link
Owner

I'll try to merge this work with #493, and move the decoding in the fronted.
This would allow the user to select the decoding method, a default should be selected based on the topic path or the first bytes of the data.

@thomasnordquist
Copy link
Owner

This should make it much easier to decode different data types in the future.

@bj00rn
Copy link
Collaborator Author

bj00rn commented May 18, 2024

I'll try to merge this work with #493, and move the decoding in the fronted. This would allow the user to select the decoding method, a default should be selected based on the topic path or the first bytes of the data.

Sounds good. An "Auto detect" mode for decoding with the possibility for manual override would be awesome. Checkout file-type https://www.npmjs.com/package/file-type package, it has detection of binary payloads. A possibility to download binary payloads would be awesome too!

@bj00rn bj00rn force-pushed the feat/use-tahu-for-sparkplug-decoding branch from f4bda3e to b04f5de Compare May 18, 2024 19:48
@bj00rn
Copy link
Collaborator Author

bj00rn commented May 20, 2024

@thomasnordquist pushed commits with sparkplug client for demoVideo

@bj00rn bj00rn force-pushed the feat/use-tahu-for-sparkplug-decoding branch from 471444e to c452b9f Compare May 20, 2024 14:42
@thomasnordquist thomasnordquist merged commit ae0ce79 into master May 24, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants