fix: catalog page composer (#234)

* chore: update pkg lock * fix: skip reset params for pagination
thoughtindustries · Nov 14, 2023 · 0cdbec7 · 0cdbec7
1 parent bdb155d
commit 0cdbec7
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 50 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/catalog/__tests__/core/utilities/manage-catalog-url/catalog-url-manager.test.ts b/packages/catalog/__tests__/core/utilities/manage-catalog-url/catalog-url-manager.test.ts
@@ -205,15 +205,6 @@ describe('@thoughtindustries/catalog/core/CatalogURLManager', () => {
       const actual = manager.composeURLForSetPage(2);
       expect(actual).toMatchInlineSnapshot(`"/base?token=abc&page=2"`);
     });
-
-    it('should reset existing params and set page when is curated', () => {
-      const searchString =
-        '?labels=%5B%22label1%22%2C%22label2%22%5D&values=%5B%22value1%22%2C%22value2%22%5D&page=3&token=abc&query=test&content-types=%5B%22type1%22%5D&display-type=calendar&sort=createdAt%3Adesc';
-      const manager = setup({ searchString, isCurated: true });
-
-      const actual = manager.composeURLForSetPage(2);
-      expect(actual).toMatchInlineSnapshot(`"/base?page=2"`);
-    });
   });
 
   describe('composeURLForRemoveToken', () => {

diff --git a/packages/catalog/src/core/utilities/manage-catalog-url/catalog-url-manager.ts b/packages/catalog/src/core/utilities/manage-catalog-url/catalog-url-manager.ts
@@ -155,7 +155,7 @@ export default class CatalogURLManager {
   }
 
   composeURLForSetPage(page: number): string {
-    const clonedParams = this._resetOrDefaultClonedParams();
+    const clonedParams = new URLSearchParams(this._searchParams);
     clonedParams.set(CatalogURLSearchParams.Page, page.toString());
     return this._composeURL(clonedParams.toString());
   }