Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use exact vite versions #212

Draft
wants to merge 4 commits into
base: staging
Choose a base branch
from
Draft

Conversation

ljiang-ti
Copy link
Contributor

unticketed

Copy link
Contributor Author

@ljiang-ti ljiang-ti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified changes in test, storybook and helium templates. the changes have some side effects, please see comments below

"react-i18next": "^11.18.6",
"use-debounce": "^7.0.1"
"use-debounce": "^9.0.4"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With changes to vite versions, the use-debounce package needs to be updated for proper settings of ESM module.

Comment on lines +34 to +35
"react": "^17 || ^18",
"react-dom": "^17 || ^18",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a note, running version updates from the root automates these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant