CLM-8328-content-tabs-component #228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diazemiliano
changed the title
rjschill87
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Apologies @diazemiliano , thought I submitted the review but saw it was pending. Let me know if you have any questions or comments.
| <> | ||
| {testimonialsToRender && | ||
| testimonialsToRender.length > 0 && | ||
| testimonialsToRender.slice(0, 5).map(testimony => { |
There was a problem hiding this comment.
Might be more of a question for @jackanticoti , but should the number of testimonials to display be configurable by the user via prop, or it is always limited to 5?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jackantico1 @rjschill87 Here a Draft of the
<ComponentTabs />component.Going as
Draftfor you to give us some feedback.