Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: naming consistency in template-base #235

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Fix: naming consistency in template-base #235

merged 2 commits into from
Nov 14, 2023

Conversation

rjschill87
Copy link
Contributor

Updates files imported w/ incorrect names and to use PascalCase for consistency.

chrisvariety
chrisvariety reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@chrisvariety chrisvariety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we need to rename the files as well for case-sensitive file systems?

e.g. Assets/hamburger.tsx => Assets/Hamburger.tsx

@rjschill87
Copy link
Contributor Author

@chrisvariety Yeah thought the files changed looked small. Forgot git missing case changes in filenames can be a thing.

chrisvariety
chrisvariety approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@chrisvariety chrisvariety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@rjschill87 rjschill87 merged commit bdb155d into staging Nov 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisvariety chrisvariety chrisvariety approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rjschill87 @chrisvariety