Allows setting nonce on generated style tags #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses a feature of webpack to extract a set nonce value on the generated style tags to allow users to maintain a Content Security Policy that does not need to use `unsafe-inline` for the styles. Updates the `makeStyleTag` function to optionally add the `nonce` attribute if the `__webpack_nonce__` value is set. Adds documentation of the feature at docs/nonce.md
|
@threepointone since this is pretty crucial for us, how can we help speed up getting this merged? In general, I see quite some useful PRs in the repo, that are stalling. |
|
Hey @swaff, since we at Signavio believe in this library we want to continue developing it further. Therefore, we've forked it and will release it as |
|
@frontendphil That is done for you now, good luck with the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a feature of webpack to extract a set nonce value on the generated
style tags to allow users to maintain a Content Security Policy that
does not need to use
unsafe-inlinefor the styles.Updates the
makeStyleTagfunction to optionally add thenonceattribute if the
__webpack_nonce__value is set.Adds documentation of the feature at docs/nonce.md