Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Upgrade eslint and plugins to latest versions #386

Closed
wants to merge 3 commits into from

Conversation

lavelle
Copy link
Contributor

@lavelle lavelle commented Jul 17, 2019

Holding off on this until airbnb config supports eslint 6

airbnb/javascript#2036

@lavelle lavelle requested a review from danoc July 17, 2019 22:02
@danoc danoc changed the title Upgrade eslint and plugins to latest versions WIP: Upgrade eslint and plugins to latest versions Jul 23, 2019
@danoc danoc removed their request for review July 25, 2019 18:02
@lavelle lavelle closed this Jul 30, 2019
@danoc
Copy link
Member

danoc commented Aug 21, 2019

Hey! It is now supported. I'll re-open this.

https://twitter.com/ljharb/status/1160221334502121472?s=21

@danoc danoc reopened this Aug 21, 2019
@lavelle
Copy link
Contributor Author

lavelle commented Aug 21, 2019

Just gave this a go. Lots of weird issues here.

  • Variables that are used are showing up us unused
  • Some overrides don't work

Seems like we should hold off until eslint or airbnb sort out their bugs

@danoc
Copy link
Member

danoc commented Oct 16, 2019

Closing this until we can pick it back up again.

@danoc danoc closed this Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants