Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tweaks #5

Merged
merged 1 commit into from Jun 26, 2019
Merged

Conversation

WearyMonkey
Copy link
Collaborator

Uses serverless-plugin-include-dependencies to detect required files from the code instead of manually specifying.

Add npx to the scripts so tsc and serverless don't need to be installed globally.

Copy link
Owner

@thundergolfer thundergolfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If allowing serverless to upgrade to 1.39.0 doesn't cause that bug i linked.

serverless.yml Outdated
@@ -15,7 +15,7 @@ service: library-management-slack-bot

# You can pin your service to only deploy with a specific Serverless version
# Check out our docs for more details
frameworkVersion: "=1.38.0"
frameworkVersion: ">=1.38.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pinned to 1.38.0 because 1.39.0 had me running into this bug. serverless/serverless#4720

@WearyMonkey WearyMonkey merged commit edf6c4f into thundergolfer:master Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants