Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Jest 24 #224

Merged
merged 7 commits into from Mar 4, 2019
Merged

feat: Jest 24 #224

merged 7 commits into from Mar 4, 2019

Conversation

thymikee
Copy link
Owner

@thymikee thymikee commented Jan 26, 2019

This is a PoC. Jest 24 works without any changes from our side. It added some defaults to TS but we use slightly different ones (e.g. no .tsx).

However, until ts-jest updates, we'll likely need to hold off with the upgrade, because of peer dep warnings.

Fixes #223

@thymikee thymikee changed the base branch from master to release/7 January 26, 2019 18:35
* origin/release/7:
  v7.0.0-alpha.2
  feat: adjust semver range of jest-zone-patch (#209)
  Adjust CHANGELOG (#208)
  Transform templateUrl, styleUrls and styles everywhere (#211)
  v7.0.0-alpha.1
  v7.0.0-alpha.0
@tonivj5
Copy link

tonivj5 commented Jan 28, 2019

it's necessary to add it/test.todo support to fix this error: TypeError: it.todo is not a function 👍

@ahnpnl
Copy link
Collaborator

ahnpnl commented Jan 30, 2019

it's necessary to add it/test.todo support to fix this error: TypeError: it.todo is not a function

is it to add to zone-patch @thymikee ?

@thymikee
Copy link
Owner Author

Yup, it's there. I'll update the PR later today (or feel free to do that for me instead, you can push to this branch)

@FrozenPandaz
Copy link
Contributor

Hi, it seems like development on this has been paused. Can this be prioritized because of the security vulnerability with jest@23.x.x? https://www.npmjs.com/advisories/786.

Are there any blockers?

@ahnpnl
Copy link
Collaborator

ahnpnl commented Mar 4, 2019

I don't see any blockers. Only one feature nice to have is it/test.todo support

@thymikee thymikee merged commit 7577c67 into release/7 Mar 4, 2019
@thymikee thymikee deleted the feat/jest24 branch March 4, 2019 17:27
thymikee added a commit that referenced this pull request Mar 4, 2019
This is a PoC. Jest 24 works without any changes from our side. It added some defaults to TS but we use slightly different ones (e.g. no `.tsx`).

However, until `ts-jest` updates, we'll likely need to hold off with the upgrade, because of peer dep warnings.

Fixes #223
@ahnpnl
Copy link
Collaborator

ahnpnl commented Mar 4, 2019

Just finished reading all and it was merged 🤣

@thymikee
Copy link
Owner Author

thymikee commented Mar 4, 2019

Released as 7.0.0-alpha.5, please test it and maybe it's time to release a stable already? ;)

@ahnpnl
Copy link
Collaborator

ahnpnl commented Mar 4, 2019

Will try immediately 👌

@FrozenPandaz
Copy link
Contributor

maybe it's time to release a stable already? ;)

Looks good to me, was able to integrate into Nx. Looking forward to the stable :)

@ahnpnl ahnpnl added this to the 7.0.0 milestone Mar 5, 2019
@ahnpnl
Copy link
Collaborator

ahnpnl commented Mar 6, 2019

apart from performance downgraded, I don't see any issues.

@thymikee
Copy link
Owner Author

thymikee commented Mar 6, 2019

We discuss perf regression here jestjs/jest#8032

If you have anything valuable to add, that would be great!

@ahnpnl
Copy link
Collaborator

ahnpnl commented Mar 6, 2019

I think originally the performance was affected by ts-jest already when we switch to ast transformer, jest 24 just adds more on top of it...

@thymikee
Copy link
Owner Author

thymikee commented Mar 6, 2019

Just to be sure, you're on 24.1, right? We had a caching regression in 24.0 fixed in minor

@ahnpnl
Copy link
Collaborator

ahnpnl commented Mar 6, 2019

ya I was on 24.1. In my opinion mainly the performance is caused by ast transformer.

@FrozenPandaz
Copy link
Contributor

Is a stable version blocked by these performance issues?

@thymikee
Copy link
Owner Author

thymikee commented Mar 8, 2019

Nope, I think we should finally release it :p

@wtho
Copy link
Collaborator

wtho commented Mar 8, 2019

👍 from my side

@ahnpnl
Copy link
Collaborator

ahnpnl commented Mar 11, 2019

Actually the performance is not so bad. Only the 1st time jest needs to recache things and after that 2nd time all the tests finished with a more less similar amount of time for my work's project comparing to v6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants