Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support jest 26 #374

Merged
merged 1 commit into from
May 18, 2020
Merged

feat: support jest 26 #374

merged 1 commit into from
May 18, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented May 16, 2020

Close #367

"testEnvironment": "jest-environment-jsdom-sixteen"
}
```
**Jest** v26 by default uses **JSDOM** 16 to support Node 10+.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is JSDOM 16 compatible with Jest 25 ? I'm not sure what to write here. Any thoughts ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be. But in 99% of the cases, whoever uses Jest v26 will be happy to use JSDOMv16 and Nodev10.
JSDOM is not a interesting test-target like IE11 or Edge, so a specific setup will not be wanted by 99% of jest users.

I think we can remove that "should also be compatible" part like you did 👍

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jest-environment-jsdom-sixteen et. al. are compatible with any version of Jest. Knowing jsdom project, they'll drop Node 10 way earlier than Jest does, so this section may still be handy. You could provide references to specific tags, so people on lower versions can refer to

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I brought back the part for providing references to specific tags as suggestion :)

"testEnvironment": "jest-environment-jsdom-sixteen"
}
```
**Jest** v26 by default uses **JSDOM** 16 to support Node 10+.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be. But in 99% of the cases, whoever uses Jest v26 will be happy to use JSDOMv16 and Nodev10.
JSDOM is not a interesting test-target like IE11 or Edge, so a specific setup will not be wanted by 99% of jest users.

I think we can remove that "should also be compatible" part like you did 👍

@ahnpnl
Copy link
Collaborator Author

ahnpnl commented May 18, 2020

shall I merge this ?

@thymikee thymikee merged commit 5afe077 into thymikee:master May 18, 2020
@thymikee
Copy link
Owner

Let's do it

@dzonatan
Copy link

When to expect a release?

@cedricduffournet
Copy link
Contributor

Can this PR be added to a new release ?

@wtho
Copy link
Collaborator

wtho commented Jun 19, 2020

Was released in 8.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Jest 26
5 participants