Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Jest 27 #676

Merged
merged 1 commit into from Dec 18, 2020
Merged

feat: support Jest 27 #676

merged 1 commit into from Dec 18, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Dec 17, 2020

Summary

Close #674

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl added the 💣 Breaking Changes Includes a breaking change and should probably wait until we're preparing for the release of a major label Dec 17, 2020
@ahnpnl ahnpnl added this to the 9.0.0 milestone Dec 17, 2020
BREAKING CHANGE
- Node 10 won't work due to jsdom bug, see jestjs/jest#10957. If you have errors with node 10 related to `globalThis`, workaround for now is switching to node 12.
- Since default `testRunner` in Jest 27 is `jest-circus`, `async` test with `done` callback no longer works, see discussion at jestjs/jest#10529. If you want to have `async` test with `done` callback, please use `testRunner: 'jest-jasmine2'` in your jest config.
@ahnpnl ahnpnl marked this pull request as ready for review December 18, 2020 12:31
@ahnpnl ahnpnl merged commit 1a6b10e into thymikee:master Dec 18, 2020
@ahnpnl ahnpnl deleted the jest-27 branch December 18, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💣 Breaking Changes Includes a breaking change and should probably wait until we're preparing for the release of a major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support jest 27
1 participant