Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presets): remove moduleNameMapper config #910

Merged
merged 1 commit into from
Apr 28, 2021
Merged

fix(presets): remove moduleNameMapper config #910

merged 1 commit into from
Apr 28, 2021

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Apr 28, 2021

Summary

Remove moduleNameMapper config from both presets, CJS and ESM

Closes #908

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

When generating a new project from Angular CLI, by default the tsconfig.json doesn't contain any path mappings hence removing moduleNameMapper from preset will make sure that the preset works in pair with tsconfig.json.

Ones who are relying on the value of moduleNameMapper from the preset should create their own moduleNameMapper config manually or via ts-jest util https://kulshekhar.github.io/ts-jest/docs/getting-started/paths-mapping

Other information

N.A.

@ahnpnl ahnpnl added the 💣 Breaking Changes Includes a breaking change and should probably wait until we're preparing for the release of a major label Apr 28, 2021
@ahnpnl ahnpnl added this to the 9.0.0 milestone Apr 28, 2021
BREAKING CHANGE
When generating a new project from Angular CLI, by default the `tsconfig.json` doesn't contain any path mappings hence removing `moduleNameMapper` from preset will make sure that the preset works in pair with `tsconfig.json`.

Ones who are relying on the value of `moduleNameMapper` from the preset should create their own `moduleNameMapper` config manually or via `ts-jest` util https://kulshekhar.github.io/ts-jest/docs/getting-started/paths-mapping
@ahnpnl ahnpnl marked this pull request as ready for review April 28, 2021 11:17
@ahnpnl ahnpnl merged commit df482bc into thymikee:master Apr 28, 2021
@ahnpnl ahnpnl deleted the fix-preset branch April 28, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💣 Breaking Changes Includes a breaking change and should probably wait until we're preparing for the release of a major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not friendly with custom paths.
1 participant