Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support all node versions >= 12.13.0 #923

Merged
merged 1 commit into from
May 17, 2021
Merged

fix: support all node versions >= 12.13.0 #923

merged 1 commit into from
May 17, 2021

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented May 16, 2021

Summary

Closes #920

Test plan

Added node 15 and node 16 to CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@@ -107,6 +107,6 @@
]
},
"engines": {
"node": "^12.14.1 || ^14.15.0"
"node": "^12.13.0 || ^14.15.0 || >=15.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity - why lower the 12.x version here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy from https://github.com/facebook/jest/blob/master/package.json#L147 . Angular requires minimum 12.14.1 starting from v12 while v9, v10, v11 doesn't require minimum 12.14.1, kind of hard to combine between Jest and Angular Node version support.

@ahnpnl ahnpnl marked this pull request as ready for review May 17, 2021 05:50
@ahnpnl ahnpnl merged commit 96782a6 into thymikee:master May 17, 2021
@ahnpnl ahnpnl deleted the node-version branch May 17, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@9.0.0-next.14 no longer works with node 15
2 participants