Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webkit mask-composite values #309

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Olivia-SY129
Copy link

Fix for mask-composite prop values for webkit

Here are the changes:

'add' → 'source-over'
'substract' → 'source-out'
'intersect' → 'source-in'
'exclude' → 'xor'

Example for element.return:

before fix (not working in webkit)
'-webkit-mask-composite: add,intersect;mask-composite: add,intersect;'  

after fix
'-webkit-mask-composite: source-over,source-in;mask-composite: add,intersect;'

@thysultan
Copy link
Owner

@Olivia-SY129 can you add a test case, i'm assuming we can replace replaceAll with just replace safe assumption?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants