prefix parameter in APIRouter does not work for websocket

[schen96]

# main.py
from fastapi import FastAPI
import myroute

import myroute
app = FastAPI()
app.include_router(myroute.router)

@app.get("/")
async def root():
    return {"message": "hello world!!"}

# myroute.py
from fastapi import APIRouter

router = APIRouter(prefix="/prefix")

# you'd expect ws://localhost:800/prefix/ws to work but only ws://localhost:800/ws connects
@router.websocket("/ws")
async def websocket_endpoint(websocket: WebSocket):

    await websocket.accept()
    await websocket.send_text("hi")
    await websocket.close()

# this works fine if you go to http://localhost:8000/prefix
@router.get("/")
def read_root():
    return {"Hello": "World"}

Description

Hi,

So with APIRouter(), the prefix path does not seem to be prepended to the websocket router path.
Not sure if its by design but if it is I feel like its quite misleading

Environment

• OS: macOS Catalina 10.15.4

• FastAPI Version: 0.63.0

• Python version: 3.8.2

[Kludex]

Bug confirmed.

Pushing a PR to fix in some minutes. Thank you for the report! @schen96

[Kludex]

Done! @tiangolo

[floriandorre]

Hi,

Thanks for the fix @Kludex, do you know if this PR going to be merged any time soon ?

[Kludex]

I have no idea. Let me ping @tiangolo

[ais-one]

Hi I would like to say that this is quite important, as I would like to move code out of the main.py file, and this feature would help me to do so...

[RuellePaul]

Same here, I would really appreciate this PR to be merged

[Sh4pe]

I'd also highly appreciate #2640 being merged.

[mh739025250]

Hope this PR to be merged soon.

[okay1204]

Still waiting over here as well.

[anton000v]

Waiting too...

@tiangolo

[kpitzen]

I am also waiting for this! :)

[OkilSaber]

Hello @tiangolo, I am also waiting for this bug fix. Thank you for your work :)

[E5presso]

Hi @tiangolo, Is there any plan to merge this?

[tiangolo]

Thanks for the report @schen96!

And thanks @Kludex for the quick fix in #2640! Sorry for the delay, there are lots of PRs to review. 😅

The fix will be available in FastAPI version 0.75.2, released in a couple of hours. 🚀

[github-actions]

Assuming the original need was handled, this will be automatically closed now. But feel free to add more comments or create new issues or PRs.