Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix support for prefix on APIRouter WebSockets #2640

Merged
merged 3 commits into from Apr 17, 2022
Merged

🐛 Fix support for prefix on APIRouter WebSockets #2640

merged 3 commits into from Apr 17, 2022

Conversation

Kludex
Copy link
Sponsor Collaborator

@Kludex Kludex commented Jan 12, 2021 •
edited by tiangolo

Related to #2639

@Kludex Kludex force-pushed the fix/router-websocket-prefix branch from 26dbf9a to 8843fe8 Compare January 12, 2021 19:01
@codecov
Copy link

codecov bot commented Jan 12, 2021 •
edited

Codecov Report

Merging #2640 (b110774) into master (cb4da93) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2640   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          529       529           
  Lines        13510     13522   +12     
=========================================
+ Hits         13510     13522   +12
Impacted Files Coverage Δ
fastapi/routing.py 100.00% <ø> (ø)
tests/test_ws_router.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb4da93...b110774. Read the comment docs.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 8843fe8 at: https://5ffdf2b21695b70981f3a279--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 6d66350 at: https://5ffdf574c2eb990e055ca0d7--fastapi.netlify.app

@Kludex Kludex mentioned this pull request Jan 12, 2021
Closed
@Kludex Kludex mentioned this pull request Mar 6, 2021
Closed
9 tasks
@Kludex Kludex mentioned this pull request Mar 23, 2021
Closed
@Kludex Kludex mentioned this pull request May 24, 2021
Closed
@Sh4pe
Copy link

Sh4pe commented Jul 6, 2021

Any chance on getting this PR merged?

@Sh4pe Sh4pe mentioned this pull request Jul 6, 2021
Closed
jpribyl
jpribyl approved these changes Jul 27, 2021
View reviewed changes
Copy link

@jpribyl jpribyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, would love to see this merged soon!

@gtors
Copy link

gtors commented Sep 9, 2021

Is there any reason why this PR is still not merged?

@jiribires jiribires mentioned this pull request Oct 12, 2021
Merged
11 tasks
@MaratBR
Copy link

MaratBR commented Feb 5, 2022

Hi! Will this PR get merged any time soon? It's been more than a year

@tiangolo

@tkieft
Copy link

tkieft commented Feb 15, 2022

@tiangolo Please merge this!

@realazizk
Copy link

Why is this not merged yet ? Are you guys afraid it will deprecate existing code ?

@tiangolo tiangolo changed the title 🐛 Consider prefix on APIRouter websockets 🐛 Fix support for prefix on APIRouter WebSockets Apr 17, 2022
@tiangolo
Copy link
Owner

Awesome, thanks @Kludex as always! 🙇 🍰

Thanks everyone for your input. 🍪

This will be available in FastAPI version 0.75.2 in a couple of hours.

@tiangolo tiangolo merged commit d81c908 into tiangolo:master Apr 17, 2022
This was referenced Apr 17, 2022
Closed
Closed
@uberbrodt uberbrodt mentioned this pull request May 19, 2022
Closed
9 tasks
JeanArhancet pushed a commit to JeanArhancet/fastapi that referenced this pull request Aug 20, 2022
@Kludex @tiangolo @JeanArhancet
🐛 Fix support for prefix on APIRouter WebSockets (tiangolo#2640)
64069e1 
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
@genagurbanguliyev
Copy link

genagurbanguliyev commented Feb 15, 2024 •
edited

Try this solved
use websocket not websocket_route

@Kludex Kludex deleted the fix/router-websocket-prefix branch February 15, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpribyl jpribyl jpribyl approved these changes

@aviramha aviramha aviramha approved these changes

@RuellePaul RuellePaul RuellePaul approved these changes

@BilalAlpaslan BilalAlpaslan BilalAlpaslan approved these changes

@yezz123 yezz123 yezz123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet