Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摑 Update data structure and render for external-links #10495

Merged
merged 2 commits into from
Oct 22, 2023

Conversation

tiangolo
Copy link
Owner

@tiangolo tiangolo commented Oct 22, 2023

馃摑 Update data structure and render for external-links

This is mainly to simplify translations, as if another language translates it but then a new section is added, all those links would not be included in that new language, so, now all the links would be included, even new ones in new sections.

The drawback is that the language and section titles will stay in English, but as all this content is mostly dynamic, it's an acceptable drawback.

@tiangolo tiangolo marked this pull request as ready for review October 22, 2023 07:31
@tiangolo tiangolo enabled auto-merge (squash) October 22, 2023 07:32
@tiangolo tiangolo merged commit e8bd645 into master Oct 22, 2023
35 checks passed
@tiangolo tiangolo deleted the external-links branch October 22, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant