-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✏️ Update links in docs/en/docs/async.md
and docs/zh/docs/async.md
to make them relative
#10498
Conversation
📝 Docs preview for commit 251f852 at: https://a5157a7b.fastapitiangolo.pages.dev |
📝 Docs preview for commit ad386f1 at: https://2a6dad0f.fastapitiangolo.pages.dev |
The fixes are correct, but
|
Ok fren. Let me check
…On Mon, 23 Oct 2023, 1:09 pm Nils Lindemann, ***@***.***> wrote:
The fixes are correct, but
- the resulting URLs are absolute, the doc server
<https://fastapi.tiangolo.com/contributing/#docs-for-tests> complains
about that in its console log. To make them relative, replace
/tutorial/dependencies/ with tutorial/dependencies/index.md and
/tutorial/dependencies/sub-dependencies/ with
tutorial/dependencies/sub-dependencies.md
- the links can also be fixed in the documents docs/em/docs/async.md
and docs/zh/docs/async.md.
—
Reply to this email directly, view it on GitHub
<#10498 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUUUDPJN5MUIMYPA6LWCWPLYAYQZZAVCNFSM6AAAAAA6LCX34OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGY2DONJXGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Some of them may already have been fixed by tiangolo#10498 (which actually inspired this PR)
📝 Docs preview for commit 0f6f145 at: https://0dbdf476.fastapitiangolo.pages.dev |
Fixing the broken url for zh lang ✨
📝 Docs preview for commit dfe1e39 at: https://059cfd30.fastapitiangolo.pages.dev |
docs/en/docs/async.md
and docs/zh/docs/async.md
to make them relative
Thanks @hasnatsajid! 🚀 And thanks for the help @nilslindemann! 🙇 |
Updated async.md for a url fix 🐛