Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Japanese translation for docs/ja/docs/python-types.md #1899

Merged
merged 18 commits into from
Jan 15, 2024
Merged

🌐 Add Japanese translation for docs/ja/docs/python-types.md #1899

merged 18 commits into from
Jan 15, 2024

Conversation

SwftAlpc
Copy link
Contributor

@SwftAlpc SwftAlpc commented Aug 15, 2020 •
edited

This PR translates the python-types.md to Japanese.
Please review python-types.md

Issue #1571 generates a new directory to support Japanese.
I will fix dependency after #1571 is merged.

@codecov
Copy link

codecov bot commented Aug 15, 2020 •
edited

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf73051) 100.00% compared to head (42212c0) 100.00%.

❗ Current head 42212c0 differs from pull request most recent head a8918fd. Consider uploading reports for the commit a8918fd to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##            master     #1899     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       239    -301     
  Lines        13969      7079   -6890     
===========================================
- Hits         13969      7079   -6890

see 356 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SwftAlpc SwftAlpc mentioned this pull request Aug 15, 2020
Closed
@github-actions
Copy link
Contributor

📝 Docs preview for commit c31e5c1 at: https://5f3841a7fb8f7817e3f538d8--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit c4219b1 at: https://5f390634fb8f783265f538e3--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Aug 16, 2020
tokusumi
tokusumi reviewed Aug 20, 2020
View reviewed changes
docs/ja/docs/python-types.md Outdated Show resolved Hide resolved
docs/ja/docs/python-types.md Outdated Show resolved Hide resolved
docs/ja/docs/python-types.md Outdated Show resolved Hide resolved
docs/ja/docs/python-types.md Outdated Show resolved Hide resolved
docs/ja/docs/python-types.md Outdated Show resolved Hide resolved
docs/ja/docs/python-types.md Show resolved Hide resolved
docs/ja/docs/python-types.md Outdated Show resolved Hide resolved
docs/ja/docs/python-types.md Outdated Show resolved Hide resolved
docs/ja/docs/python-types.md Outdated Show resolved Hide resolved
docs/ja/docs/python-types.md Outdated Show resolved Hide resolved
@SwftAlpc
Copy link
Contributor Author

@tokusumi
Except for the unification part of the notation, I fixed it!
Thanks for the review!

@github-actions
Copy link
Contributor

📝 Docs preview for commit eb296fb at: https://5f3ea0b9b1f979f93069e21d--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit 8e4a2d9 at: https://5f4152abc86c100e9ddfb375--fastapi.netlify.app

tokusumi
tokusumi approved these changes Aug 22, 2020
View reviewed changes
Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
It's grateful to translate one of difficult parts.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 42212c0 at: https://5f4cb0e9b8506639cf43d129--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit f94aa5c at: https://5f9a97477931482110142032--fastapi.netlify.app

@tokusumi tokusumi mentioned this pull request Jun 5, 2021
Closed
@tiangolo tiangolo changed the title Add Japanese translation for python-types.md 🌐 Add Japanese translation for python-types.md Jun 26, 2023
@tiangolo tiangolo changed the title 🌐 Add Japanese translation for python-types.md 🌐 Add Japanese translation for docs/ja/docs/python-types.md Jun 26, 2023
@tiangolo tiangolo added lang-ja Japanese translations awaiting-review and removed lang-ja Japanese translations awaiting-review labels Jun 26, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit a8918fd at: https://6499bf7adedfc40c9911d13d--fastapi.netlify.app

@alejsdev
Copy link
Collaborator

Thanks for your help @SwftAlpc 🚀

And thanks for the review @tokusumi 🍰

@alejsdev alejsdev merged commit efac3a2 into tiangolo:master Jan 15, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokusumi tokusumi tokusumi approved these changes

Assignees
No one assigned
Labels
awaiting-review lang-all Translations lang-ja Japanese translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SwftAlpc @tiangolo @alejsdev @tokusumi @ryuckel