Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Japanese translation for docs/ja/docs/tutorial/encoder.md #1955

Merged
merged 21 commits into from
Jan 22, 2024

Conversation

SwftAlpc
Copy link
Contributor

@SwftAlpc SwftAlpc commented Aug 23, 2020

This PR translates the tutorial/encoder.md to Japanese.
Please review tutorial/encoder.md.

Issue #1571 generates a new directory to support Japanese.
PR #1656 generates a new directory for tutorial.
I will fix dependency after #1571 & #1656 are merged.

@SwftAlpc SwftAlpc mentioned this pull request Aug 23, 2020
@codecov
Copy link

codecov bot commented Aug 23, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf73051) 100.00% compared to head (596c363) 100.00%.
Report is 1086 commits behind head on master.

❗ Current head 596c363 differs from pull request most recent head 5f4ea5f. Consider uploading reports for the commit 5f4ea5f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #1955     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files          540       239    -301     
  Lines        13969      7079   -6890     
===========================================
- Hits         13969      7079   -6890     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

📝 Docs preview for commit 3ac387f at: https://5f4240c9442f8e5162c9c3d7--fastapi.netlify.app

@tiangolo tiangolo added awaiting-review lang-all Translations lang-ja Japanese translations labels Aug 29, 2020
@github-actions
Copy link
Contributor

📝 Docs preview for commit ba67d8e at: https://5f4cbf585bf93042c9ad3a86--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved your translation.
I add a not important comment. please refer it if you want


JSON互換のデータのみを受信するデータベース`fase_db`があるとしましょう。

例えば、`datetime`オブジェクトはJSONと互換性がないので受け取りません。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

例えば、datetimeオブジェクトはJSONと互換性がないので、このデータベースには受け取られません。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adopt this one because it's a clearer Japanese translation!

@SwftAlpc
Copy link
Contributor Author

@tokusumi
Thanks for the review!
May I ask for confirmation?

@github-actions
Copy link
Contributor

📝 Docs preview for commit 596c363 at: https://5f9ae349df0a3a0a6bf7176e--fastapi.netlify.app

Copy link
Contributor

@tokusumi tokusumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you.

Copy link

@delhi09 delhi09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks mostly good.
I pointed out some details.


## `jsonable_encoder`の使用

JSON互換のデータのみを受信するデータベース`fase_db`があるとしましょう。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"fake_db" in original sentence.
(Probably its's typo and I know its's a mere example db name.)


JSON互換のデータのみを受信するデータベース`fase_db`があるとしましょう。

例えば、`datetime`オブジェクトはJSONと互換性がないので、このデーターベースには受け取られません。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a little better to modify "データーベース" to "データベース" because elsewhere it is referred to as "データベース".

@tiangolo tiangolo changed the title Add tutorial/encoder.md Japanese ver 🌐 Add Japanese translation for docs/ja/docs/tutorial/encoder.md Jun 26, 2023
@tiangolo
Copy link
Owner

📝 Docs preview for commit 5f4ea5f at: https://6499ca883df3740528860850--fastapi.netlify.app

@alejsdev alejsdev merged commit 851daec into tiangolo:master Jan 22, 2024
32 checks passed
@alejsdev
Copy link
Collaborator

Thank you! @SwftAlpc 🤓

And thanks to everyone else for the reviews 🧐🔍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved-1 lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants