-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Japanese translation for docs/ja/docs/advanced/conditional-openapi.md
#2631
🌐 Add Japanese translation for docs/ja/docs/advanced/conditional-openapi.md
#2631
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2631 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 531 531
Lines 13629 13629
=========================================
Hits 13629 13629 Continue to review full report at Codecov.
|
📝 Docs preview for commit d0161ad473c8d24f64398c86ae4dd3e81b7fcee8 at: https://5ffc84dd1e18095cdf40edaa--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for translation, great work!
I propose some improvements (and alternative).
|
||
必要であれば、設定と環境変数を利用して、OpenAPIを環境に応じて構成することが可能です。また、完全にOpenAPIを無効にすることもできます。 | ||
|
||
## セキュリティとAPI、ドキュメントについて |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## セキュリティとAPI、ドキュメントについて | |
## セキュリティとAPIとドキュメントについて |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just changed to "## セキュリティとAPI、およびドキュメントについて" since I think "AとBとC" is a bit hard to read. Please let me know if it does not follow your suggestion.
d0161ad
to
7711bf4
Compare
@tokusumi Thank you for your quick review. Updated! |
📝 Docs preview for commit 7711bf4 at: https://600285ce685d265c1fd72553--fastapi.netlify.app |
LGTM👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!!
I propose that "conditional noun" would be translated as "条件付き noun". Since;
- In mathematical term, "conditional probability" and "conditional expectation" are translated as "条件付き確率" and "条件付き期待値", respectively.
- In azure doc (en, ja), "conditional access" is translated as "条件付きアクセス".
and I leave some improvements. Please take them if you feel they make this article better!
be41bd7
to
66eb927
Compare
📝 Docs preview for commit 66eb927 at: https://624bb44928025e2c48d0fea9--fastapi.netlify.app |
@wakabame All points makes sense enough and fixed all! could you check again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sh0nk
LGTM!
Thank you for your quick action!!
docs/ja/docs/advanced/conditional-openapi.md
📝 Docs preview for commit 32bed26 at: https://62795e20b66d6316da0263a8--fastapi.netlify.app |
…napi.md` (tiangolo#2631) Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
This PR translates advanced/conditional-openapi.md in Japanese.
This is my first PR to FastAPI docs by referring to https://fastapi.tiangolo.com/contributing/#existing-language . If I do any mistake, please let me know!
Also, I found this comment in an issue. Let me try to review the open PRs for Japanese translation since a lot of parts are already done but not reviewed in progress.