-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Add Japanese translation for docs/ja/docs/advanced/nosql-databases.md
#4205
🌐 Add Japanese translation for docs/ja/docs/advanced/nosql-databases.md
#4205
Conversation
docs/ja/docs/advanced/nosql-databases.md
📝 Docs preview for commit 96bd631 at: https://61b0caec4bb4cd2a61ab32e4--fastapi.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #4205 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 532 532
Lines 13672 13672
=========================================
Hits 13672 13672 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a native speaker, but this seems solid!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!!
@tiangolo this should be ready, let's merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for great work!!!
I'd like to suggests the followings, although already you've gotten enough approve.
@@ -0,0 +1,155 @@ | |||
# NoSQL (分散 / ビッグデータ) Databases | |||
|
|||
**FastAPI** はあらゆる <abbr title="分散データベース (Big Data), や 'Not Only SQL'">NoSQL</abbr>と統合することもできます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**FastAPI** はあらゆる <abbr title="分散データベース (Big Data), や 'Not Only SQL'">NoSQL</abbr>と統合することもできます。 | |
**FastAPI** はあらゆる <abbr title="分散データベース (Big Data)や 'Not Only SQL'">NoSQL</abbr>と統合することもできます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could omit "," or put it after "や"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL3
|
||
この関数では: | ||
|
||
* **Couchbase** クラスタ(1台の場合もあるでしょう)に接続し |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too rough writing are used than other sections. I suggest to delete some "し" and "して" at all lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you to suggests. I applied arround here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL48
|
||
## Pydantic モデルの作成 | ||
|
||
**Couchbase**のdocumentは実際には単にJSONオブジェクトなのでPydanticを利用してモデルにすることが出来ます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**Couchbase**のdocumentは実際には単にJSONオブジェクトなのでPydanticを利用してモデルにすることが出来ます。 | |
**Couchbase**のdocumentは実際には単にJSONオブジェクトなのでPydanticを利用してモデルに出来ます。 |
Suggesting shorten expression at the end of a sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL63
{!../../../docs_src/nosql_databases/tutorial001.py!} | ||
``` | ||
|
||
このモデルは*path operation*で利用できる関数で使用するので`hashed_password`はモデルに含めません。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
このモデルは*path operation*で利用できる関数で使用するので`hashed_password`はモデルに含めません。 | |
このモデルは*path operation*に使用するので、`hashed_password`は含めません。 |
This is difficult to translate. Here, path operation
(function) refer to read_user
function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL73
{!../../../docs_src/nosql_databases/tutorial001.py!} | ||
``` | ||
|
||
!!! note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!!! note | |
!!! note "備考" |
Unified at translation tracking issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL87
|
||
それでは次の関数を作成しましょう: | ||
|
||
* username を取得して |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above suggestion. Deleting "して" or Replacing with "する" are better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL96
{!../../../docs_src/nosql_databases/tutorial001.py!} | ||
``` | ||
|
||
### f-strings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### f-strings | |
### f-strings | |
Maybe newline needs after heading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL96
|
||
## "document type" として利用する定数の定義 | ||
|
||
documentで利用する固定のフィールド`type`を用意しておきます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
documentで利用する固定のフィールド`type`を用意しておきます。 | |
documentで利用する固定の`type`フィールドを用意しておきます。 |
More easier to read?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL28
* **ArangoDB** | ||
* **ElasticSearch** など。 | ||
|
||
!!! 豆知識 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!!! 豆知識 | |
!!! tip "豆知識" |
I'm not sure but maybe this is (or was) right syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you to suggests. I applied at here.
6866770#diff-101eb49c79208a3498543c29b9170aaabf8ce9c8dbdc16b3eb63f4010c9081eeL15
📝 Docs preview for commit 99a1523 at: https://62ad80850151d34b7adb7eb3--fastapi.netlify.app |
Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com>
📝 Docs preview for commit 0b29c08 at: https://62add7c6b9dd507f67334965--fastapi.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the contribution @sUeharaE4! 🍰 And thank you for the reviews @dimaqq, @wakabame, and @tokusumi! ☕ |
….md` (tiangolo#4205) Co-authored-by: tokusumi <41147016+tokusumi@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Relates to #1572
This PR translates advanced/nosql-databases.md.
I left "databases" in the page title as it is because there is no word for the plural of database in Japanese.
This is my first pull request, so I apologize if there are any problems. I would appreciate it if you could check it.