👷♂️ Consistently use sys.executable to run subprocesses, needed by OpenSUSE
#408
Conversation
|
📝 Docs preview for commit 04a0e70 at: https://62b5fdf9cc5bd304bad2e920--typertiangolo.netlify.app |
theMarix
force-pushed
the
run-subprocesses-with-correct-python
branch
from
04a0e70
to
7fce85d
Compare
Codecov ReportBase: 96.24% // Head: 100.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #408 +/- ##
===========================================
+ Coverage 96.24% 100.00% +3.75%
===========================================
Files 280 252 -28
Lines 5942 5370 -572
===========================================
- Hits 5719 5370 -349
+ Misses 223 0 -223
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
theMarix
force-pushed
the
run-subprocesses-with-correct-python
branch
from
7fce85d
to
b2ed091
Compare
|
📝 Docs preview for commit 9bc91d5 at: https://6366753ee3a47378ef50daa8--typertiangolo.netlify.app |
|
📝 Docs preview for commit fde13f7 at: https://636675ef52cfab79cb9f3258--typertiangolo.netlify.app |
theMarix
force-pushed
the
run-subprocesses-with-correct-python
branch
from
fde13f7
to
53eaf7e
Compare
|
📝 Docs preview for commit 53eaf7e at: https://636805da6d69cd0402127c6d--typertiangolo.netlify.app |
In some scenarios, like running pytest outside of an active virtualenv, it could happen that "coverage" would refer to a different Python interpreter than the one running the tests. Admittedly that does not happen in standard development scenarios where you use a virtualenv. But it easily happens when packaging for Linux distributions that support multiple versions of Python and it can also happen when running pytest from a virtualenv without activating it. The latter is something that's convenient when testing versus multiple Python versions without using tox. Explicitly invoking coverage as a module on sys.executable ensures that the same binary, not process, that's also running the tests is used. This was in fact already done in some tests but not consistently across all of them.
theMarix
force-pushed
the
run-subprocesses-with-correct-python
branch
from
53eaf7e
to
1f64f55
Compare
|
📝 Docs preview for commit 1f64f55 at: https://636808c83d1e860a554c222b--typertiangolo.netlify.app |
|
📝 Docs preview for commit 501e25e at: https://636946baf62f600f21622fd6--typertiangolo.netlify.app |
tiangolo
changed the title
sys.executable to run subprocesses, needed by OpenSUSE
|
Cool, thanks! Let's do it! 🚀 |
In some scenarios, like running pytest outside of an active virtualenv,
it could happen that "coverage" would refer to a different Python
interpreter than the one running the tests. Admittedly that does not
happen in standard development scenarios where you use a virtualenv. But
it easily happens when packaging for Linux distributions that support
multiple versions of Python and it can also happen when running pytest
from a virtualenv without activating it. The latter is something that's
convenient when testing versus multiple Python versions without using
tox.
Explicitly invoking coverage as a module on sys.executable ensures that
the same binary, not process, that's also running the tests is used.
This was in fact already done in some tests but not consistently across
all of them.