New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): be able to add plugins to build.gradle #14019
base: master
Are you sure you want to change the base?
Conversation
feat(android): plugins classpathes to manifest feat(android): custom root.build.gradle for modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor code style issue, thanks!
Co-authored-by: Hans Knöchel <hansemannn@users.noreply.github.com>
Of course! Thanks 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR looks good from my end. @m1ga Any objections?
I guess I need to add a couple of more things to make this PR feature solid. |
i've not tested it as I don't have any test case or knowledge how to use plugins in a gradle file. But if it works for you and doens't break the usual stuff (module build, app build, hyperloop app, kitchensink app) then go for it 😄 |
@hansemannn @m1ga This was the last commit needed to this PR, I've tested it from my side and it's all good now and ready to be merged, as for the documentation of how to use this, we need to add the update here, if you can tag me on where this is editable so I can work on the documentation of this new feature. |
Nice, that will be in this repo: https://github.com/tidev/titanium-docs/tree/main/docs/guide/Titanium_SDK/Titanium_SDK_How-tos/Extending_Titanium_Mobile |
Cool |
Hyperloop apps won't build.
The generated build.gradle file looks like this:
so it didn't replace the loop. |
Module also won't build:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check if this.manifest.plugins is there before splitting
check if this.manifest.plugins is there before splitting
@m1ga can you please review this, thanks! |
path.join(this.buildDir, 'build.gradle')); | ||
let buildGradleContent = await fs.readFile(path.join(templatesDir, 'root.build.gradle')); | ||
buildGradleContent = ejs.render(buildGradleContent.toString(), { | ||
classpathes: this.manifest.classpathes.split(','), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add the same fix here
with the fixes I still get
when building a module as it will add an empty
|
The hyperloop error also still exists. To test it: clone and build https://github.com/tidev/hyperloop-examples |
@m1ga I'll try to work on it today and finish it ASAP. |
feat(android): added classpathes to manifest
feat(android): add plugins to manifest
feat(android): custom root.build.gradle for modules