API improvements to support RushJS integration #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes improve logging for microsoft/rushstack#4594.
To reduce confusion, rename
storePath
todotPnpmFolder
and avoid referring to it as the "store"馃憠 The PNPM "store" is a different folder from the "virtual store" (
.pnpm
folder), and PNPM itself is somewhat vague about whether the "virtual store" means the.pnpm
folder or actually its subfolder pathsFix a bug where
postbuildInjectedCopy.sourceFolder
andtargetFolders
were calculated with an extra..
because they were relative topnpmSyncJsonPath
which is a file, not a directorypnpm-sync
CLI now returns nonzero exit code for errors/warningsAdd
--verbose
CLI parameter for testing verbose eventsProvide an importable name for
ILogMessageCallbackOptions.details
Add API docs for
IPnpmSyncCopyOptions
andIPnpmSyncPrepareOptions
Rename
COPY_PROCESSING
to ``COPY_ERROR_NO_SYNC_FILE` to more clearly indicate that it is an error.Introduce new log events
PREPARE_ERROR_UNSUPPORTED_FORMAT
andPREPARE_WRITING_FILE
Add more
details
fields to the various log eventsThe millisecond timings are now
number
instead ofstring
to permit the caller to format themRemove
pnpm-sync:
prefix from log messages so the caller can do thatImprove grammar to avoid a
Synced 1 files
messageIPnpmSyncCopyOptions.pnpmSyncJsonPath
is no longer optional because API's should not be designed aroundprocess.cwd()
and also a correct implementation needs to test existence of that file before calling the APIRemove
IPnpmSyncCopyOptions
parameter destructuring because this is an implementation detail that clutters the public API docs@g-chao