ci: transitioning action version from node 16 to node 20 #8071

HuSharp · 2024-04-16T02:58:02Z

What problem does this PR solve?

Issue Number: Close #8070

What is changed and how does it work?

Check List

Tests

No code

Release note

None.

Signed-off-by: husharp <jinhao.hu@pingcap.com>

ti-chi-bot · 2024-04-16T02:58:04Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

nolouch
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ti-chi-bot · 2024-04-16T02:58:04Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Signed-off-by: husharp <jinhao.hu@pingcap.com>

codecov · 2024-04-16T03:27:09Z

Codecov Report

Merging #8071 (07dd253) into master (22543a9) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 07dd253 differs from pull request most recent head c04dca0. Consider uploading reports for the commit c04dca0 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8071      +/-   ##
==========================================
+ Coverage   77.28%   77.30%   +0.01%     
==========================================
  Files         469      469              
  Lines       61097    61097              
==========================================
+ Hits        47218    47229      +11     
+ Misses      10325    10302      -23     
- Partials     3554     3566      +12

Flag	Coverage Δ
unittests	`77.30% <ø> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp · 2024-04-16T05:31:58Z

.github/workflows/pd-tests.yaml

+          pattern: cover-reports-*
+          merge-multiple: true


added because
https://github.com/actions/upload-artifact/blob/ef09cdac3e2d3e60d8ccadda691f4f1cec5035cb/docs/MIGRATION.md#multiple-uploads-to-the-same-named-artifact

the pattern: input will filter the downloaded Artifacts to match the name specified.

the merge-multiple: input will support downloading multiple Artifacts to the same directory.

HuSharp · 2024-04-16T05:33:01Z

.github/workflows/pd-tests.yaml

-          path: |
-            ~/go/pkg/mod
-            ~/.cache/go-build
-            **/.tools
-            **/.dashboard_download_cache
-          key: ${{ runner.os }}-go-${{ matrix.worker_id }}-${{ hashFiles('**/go.sum') }}


removed because have cached in setup actions/cache#1104 (comment)

Otherwise, we will meet error

HuSharp · 2024-04-16T05:33:37Z

.github/workflows/check.yaml

      - name: Checkout code
-        uses: actions/checkout@v3
-      - name: Restore cache
-        uses: actions/cache@v3
+        uses: actions/checkout@v4
+      - uses: actions/setup-go@v5


change the checkout and setup place because actions/setup-node#624 (comment)

HuSharp · 2024-04-16T05:37:12Z

.github/workflows/check.yaml

-        uses: actions/cache@v3
+        uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
        with:
-          path: |
-            ~/go/pkg/mod
-            ~/.cache/go-build
-            **/.dashboard_download_cache
-          key: ${{ runner.os }}-golang-${{ hashFiles('**/go.sum') }}
-          restore-keys: |
-            ${{ runner.os }}-golang


removed because have cached in setup actions/cache#1104 (comment)

HuSharp · 2024-04-16T09:20:12Z

/merge

ti-chi-bot · 2024-04-16T09:20:14Z

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2024-04-16T09:20:16Z

This pull request has been accepted and is ready to merge.

Commit hash: 07dd253

ti-chi-bot · 2024-04-16T09:20:29Z

@HuSharp: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

bump action

c563883

Signed-off-by: husharp <jinhao.hu@pingcap.com>

ti-chi-bot bot added release-note-none do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 16, 2024

ti-chi-bot bot requested a review from JmPotato April 16, 2024 02:58

ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 16, 2024

bump action

2e5f0a1

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp removed the request for review from JmPotato April 16, 2024 03:04

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 16, 2024

HuSharp force-pushed the update_node16_to_20 branch 2 times, most recently from 5b1cc8c to 16a8b73 Compare April 16, 2024 03:52

fix cache

dab2894

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp force-pushed the update_node16_to_20 branch from 627a9b6 to dab2894 Compare April 16, 2024 05:20

HuSharp requested review from nolouch, lhy1024 and rleungx April 16, 2024 05:31

HuSharp marked this pull request as ready for review April 16, 2024 05:31

ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2024

HuSharp commented Apr 16, 2024

View reviewed changes

HuSharp requested a review from JmPotato April 16, 2024 05:48

Merge branch 'master' into update_node16_to_20

07dd253

nolouch approved these changes Apr 16, 2024

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 16, 2024

rleungx approved these changes Apr 16, 2024

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 16, 2024

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 16, 2024

Merge branch 'master' into update_node16_to_20

c04dca0

ti-chi-bot bot merged commit acbb9af into tikv:master Apr 16, 2024
22 checks passed

HuSharp deleted the update_node16_to_20 branch April 16, 2024 10:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: transitioning action version from node 16 to node 20 #8071

ci: transitioning action version from node 16 to node 20 #8071

HuSharp commented Apr 16, 2024 •

edited

ti-chi-bot bot commented Apr 16, 2024 •

edited

ti-chi-bot bot commented Apr 16, 2024

codecov bot commented Apr 16, 2024 •

edited

HuSharp Apr 16, 2024 •

edited

HuSharp Apr 16, 2024 •

edited

HuSharp Apr 16, 2024

HuSharp Apr 16, 2024 •

edited

HuSharp commented Apr 16, 2024

ti-chi-bot bot commented Apr 16, 2024

ti-chi-bot bot commented Apr 16, 2024

ti-chi-bot bot commented Apr 16, 2024

ci: transitioning action version from node 16 to node 20 #8071

ci: transitioning action version from node 16 to node 20 #8071

Conversation

HuSharp commented Apr 16, 2024 • edited

What problem does this PR solve?

What is changed and how does it work?

problems

solution

action release note and docs

Check List

Release note

ti-chi-bot bot commented Apr 16, 2024 • edited

ti-chi-bot bot commented Apr 16, 2024

codecov bot commented Apr 16, 2024 • edited

Codecov Report

HuSharp Apr 16, 2024 • edited

Choose a reason for hiding this comment

HuSharp Apr 16, 2024 • edited

Choose a reason for hiding this comment

HuSharp Apr 16, 2024

Choose a reason for hiding this comment

HuSharp Apr 16, 2024 • edited

Choose a reason for hiding this comment

HuSharp commented Apr 16, 2024

ti-chi-bot bot commented Apr 16, 2024

ti-chi-bot bot commented Apr 16, 2024

ti-chi-bot bot commented Apr 16, 2024

HuSharp commented Apr 16, 2024 •

edited

ti-chi-bot bot commented Apr 16, 2024 •

edited

codecov bot commented Apr 16, 2024 •

edited

HuSharp Apr 16, 2024 •

edited

HuSharp Apr 16, 2024 •

edited

HuSharp Apr 16, 2024 •

edited