Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Don't touch native projects. #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

merqlove
Copy link

Here was a trouble with false positive checking for library binaries, even if we have binary projects (CLI and so on). So i think better don't touch projects without Gemfile inside.

@wagenet
Copy link
Collaborator

wagenet commented May 15, 2017

@merqlove can you give me a more specific example of the scenario in which this was an issue?

@merqlove
Copy link
Author

merqlove commented May 15, 2017 via email

@merqlove
Copy link
Author

Simple example of such structure:

screenshot 2017-05-15 23 04 24

@merqlove
Copy link
Author

Hi, @wagenet you understood that problem?

@merqlove
Copy link
Author

Also, here can be optional setup ability for binary-only projects, i mean ability to enable/disable Helix functions: copy library, check state or change copy/destination path.
Currently here is a always error on sp_cli native library copy action, if helix without such changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants