imagehelper - filename (towebp, tojpg)

[EpicKau]

Fixes #897

Issue

files are not deleted, when they were generated through timber filter. (webp, png)

Solution

Change generated filenames to have target fileformat in the filename.
Added more calls to delete_generated_files with specific regex for fileformat

I hope it helps.

[jarednova]

Thanks so much @EpicKau ! It looks like some tests need to be updated to match with this new naming convention. Could you give it a look?

[EpicKau]

@jarednova So what I see is that most time the test failed because of "assertFileExists" check. ("Failed asserting that file "XYZ" exists.")
That makes sense because the output file has another name than the input file.
E.g. XYZ-tojpg.jpg instead of XYZ.jpg.

[jarednova]

Exactly @EpicKau (at least, that's what it looks like) — just need to reflect the new expected naming convention

[coveralls]

Coverage increased (+0.007%) to 92.301% when pulling ffc3b39 on EpicKau:master into 68bb27b on timber:master.

[Levdbas]

So I ran into this issue #2748 as well and found this PR after some digging. #2535 seems to be related as well.

I did some local tests and this pr fixes both problems for me. both the webp and and jpg generated images are removed.

Only files that are not accounted for are when running towebp and tojpg on crops that will result to filenames like these.

test-400x267-towebp.webp
test-400x267-tojpg.jpg

[gchtr]

With this change, websites that use the ToJpg and ToWebp operations will be left with quite a few stray webp and jpg images.

Do we have to consider this as a breaking change? Because I see the following problems here:

• It will trigger the images to be regenerated and for sites with a lot of images, right? This could create performance issues or even max execution time errors.
• It might have serious impact on the whole size of the website, which could lead to problems on websites that have a limited available space.