Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allow Timber\PostExcerpt::read_more to accept bool value #2937

Merged
merged 2 commits into from
May 15, 2024

Conversation

Levdbas
Copy link
Member

@Levdbas Levdbas commented Feb 28, 2024

Related:

Issue

The [Timber\PostPreview::read_more](https://timber.github.io/docs/reference/timber-postpreview/#read_more) docs say:

    Set this to false to not add a "Read More" link.

But Timber\PostPreview::read_more doesn't actually accept a boolean value, it only accepts a string value type. 馃槵

Solution

Port changes of #2578 to v2.

Impact

Usage Changes

No

Considerations

Testing

Already covered by tests in TestTimberPostExcerptObject::testExcerptConstructorWithWords

@coveralls
Copy link

coveralls commented Feb 28, 2024

Coverage Status

coverage: 87.745% (-0.06%) from 87.807%
when pulling 894e214 on postexcert-readmore
into 13c6b0f on 2.x.

@Levdbas Levdbas added this to the 2.2.0 milestone May 10, 2024
src/PostExcerpt.php Outdated Show resolved Hide resolved
Co-authored-by: Lukas G盲chter <lukas.gaechter@mind.ch>
@Levdbas Levdbas merged commit 85e2a32 into 2.x May 15, 2024
22 of 24 checks passed
@Levdbas Levdbas deleted the postexcert-readmore branch May 15, 2024 10:25
This was referenced May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants