Avoid projection more often in DecompressChunk node #6859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently its scan targetlist is always the uncompressed tuple, but in some cases we can make the scan targetlist the same as the output targetlist, thus avoiding the projection.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6859 +/- ##
==========================================
+ Coverage 80.06% 81.74% +1.67%
==========================================
Files 190 199 +9
Lines 37181 36942 -239
Branches 9450 9654 +204
==========================================
+ Hits 29770 30198 +428
+ Misses 2997 2862 -135
+ Partials 4414 3882 -532 ☔ View full report in Codecov by Sentry. |
4 tasks
svenklemm
approved these changes
May 3, 2024
antekresic
approved these changes
May 28, 2024
tsl/src/nodes/vector_agg/plan.c
Outdated
| Var *var = castNode(Var, node); | ||
| if (var->varno != OUTER_VAR) | ||
| Var *aggregated_var = castNode(Var, node); | ||
| if (aggregated_var->varno != OUTER_VAR) |
There was a problem hiding this comment.
Can you add a test to cover this branch as well?
There was a problem hiding this comment.
I think it just can't happen, I'll change it to an assertion.
Co-authored-by: Ante Kresic <antekresic@users.noreply.github.com> Signed-off-by: Alexander Kuzmenkov <36882414+akuzm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently its scan targetlist is always the uncompressed tuple, but in some cases we can make the scan targetlist the same as the required output targetlist, thus avoiding the projection.
This is required to enable vectorized aggregation in more cases, but is also a performance improvement in itself. In tsbench, it gives up to 25% speedup for some queries: https://grafana.ops.savannah-dev.timescale.com/d/fasYic_4z/compare-akuzm?orgId=1&var-branch=All&var-run1=3461&var-run2=3469&var-threshold=0&var-use_historical_thresholds=true&var-threshold_expression=2.5%20%2A%20percentile_cont%280.90%29&var-exact_suite_version=false&from=now%2Fy&to=now%2Fy
This partially implements https://github.com/timescale/eng-database/issues/564
Disable-check: force-changelog-file