-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow replica identity on compressed hypertables #6897
Conversation
16e69fa
to
0c9d6f5
Compare
SELECT relname, relreplident FROM pg_class WHERE relname = 'test1' ORDER BY relname; | ||
relname | relreplident | ||
---------+-------------- | ||
test1 | f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can u run it before and after changing the replica identity to make evident that it changed properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you only forgot to also run the check for the hypertable itself before changing the replica identity like you did for chunks. Other than that LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
(1 row) | ||
|
||
-- the chunk's setting should also change to FULL | ||
SELECT relname, relreplident FROM show_chunks('test1') ch INNER JOIN pg_class c ON (ch = c.oid) ORDER BY relname; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SELECT relname, relreplident FROM show_chunks('test1') ch INNER JOIN pg_class c ON (ch = c.oid) ORDER BY relname; | |
SELECT relreplident, COUNT(*) FROM show_chunks('test1') ch INNER JOIN pg_class c ON (ch = c.oid) GROUP BY 1 ORDER BY 1; |
Decrease the test output size... also be good to run it before and after change the replica identity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
0c9d6f5
to
e24d54e
Compare
e24d54e
to
c1c2fcc
Compare
This unblocks the execution of `ALTER TABLE ... REPLICA IDENTITY ...` on hypertables with compression enabled. The configured replica identity only propagates to tables belonging to the uncompressed hypertable. Fixes: #6158
c1c2fcc
to
cd04a4d
Compare
No description provided.