Skip to content

Commit

Permalink
Update doc/devel/pr_guide.rst
Browse files Browse the repository at this point in the history
Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
  • Loading branch information
timhoffm and tacaswell committed May 6, 2024
1 parent 6c2e73b commit 11de885
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions doc/devel/pr_guide.rst
Expand Up @@ -212,10 +212,9 @@ Some explicit rules following from this:
the flow of championed PRs reasonable.

After giving the last required approval, the author of the approval should
merge the PR. PR authors must not self-merge, except for when another reviewer
merge the PR. PR authors should not self-merge except for when another reviewer
explicitly allows it (e.g., "Approve modulo CI passing, may self merge when
green", or "Take or leave the comments. You may self merge".).
Core developers may also self-merge in exceptional emergency situations.

.. _pr-automated-tests:

Expand Down

0 comments on commit 11de885

Please sign in to comment.