Skip to content

Commit

Permalink
Merge pull request #78 from timkpaine/tkp/hf
Browse files Browse the repository at this point in the history
Hotfix to only build once
  • Loading branch information
timkpaine committed Apr 11, 2022
2 parents 41faf13 + 65df9fe commit a13bde4
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 23 deletions.
7 changes: 4 additions & 3 deletions MANIFEST.in
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ include setup.cfg
include pyproject.toml
include Makefile

recursive-include ipydagred3/extension *.*
recursive-include ipydagred3/labextension *.*
recursive-include ipydagred3/nbextension *.*
graft ipydagred3
graft ipydagred3/extension
graft ipydagred3/labextension
graft ipydagred3/nbextension

# grab js
graft js
Expand Down
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ fix: fixpy fixjs ## run black/tslint fix

check: checks
checks: ## run lint and other checks
check-manifest
check-manifest -v

build: clean ## build python/javascript
python -m build . -s -w
build: ## build python/javascript
python -m build .

develop: ## install to site-packages in editable mode
python -m pip install --upgrade build pip setuptools twine wheel
Expand Down
2 changes: 1 addition & 1 deletion ipydagred3/_version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.3.3"
__version__ = "0.3.4"
4 changes: 2 additions & 2 deletions js/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ipydagred3",
"version": "0.3.3",
"version": "0.3.4",
"description": "A Custom Jupyter Widget Library",
"keywords": [
"jupyter",
Expand Down Expand Up @@ -31,7 +31,7 @@
"build:babel": "babel src/ --source-maps --out-dir lib/",
"build:labextension": "jupyter labextension build .",
"build:nbextension": "webpack --mode=production",
"build": "npm-run-all build:*",
"build": "npm-run-all clean build:*",
"clean": "npm-run-all clean:*",
"clean:lib": "rimraf lib",
"clean:labextension": "rimraf ../ipydagred3/labextension",
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[build-system]
requires = ["setuptools", "wheel", "jupyter-packaging<2", "jupyterlab>=3"]
build-backend = "setuptools.build_meta"
build-backend = "jupyter_packaging.build_api"
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[bumpversion]
current_version = 0.3.3
current_version = 0.3.4
commit = True
tag = False

Expand Down
22 changes: 10 additions & 12 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@

data_spec = [
# Lab extension installed by default:
("share/jupyter/nbextensions/ipydagred3", nb_path, "*.js*"),
("share/jupyter/nbextensions/ipydagred3", nb_path, "**"),
("etc/jupyter/nbconfig/notebook.d", ext_path, "ipydagred3.json"),
(
"share/jupyter/labextensions/ipydagred3",
Expand All @@ -66,16 +66,18 @@
]

ensured_targets = [
pjoin(jshere, "lib", "index.js"),
pjoin(jshere, "style", "index.css"),
pjoin(lab_path, "package.json"),
pjoin(lab_path, "static", "style.js"),
pjoin(nb_path, "index.js"),
]

builder = npm_builder(build_cmd="build", path=jshere)
builder = npm_builder(
build_cmd="build", path=jshere, source_dir=pjoin(jshere, "src"), build_dir=lab_path
)

setup(
name=name,
version="0.3.3",
version="0.3.4",
description="ipywidgets wrapper around dagre-d3",
long_description=long_description,
long_description_content_type="text/markdown",
Expand All @@ -99,19 +101,15 @@
post_develop=builder, pre_dist=builder, ensured_targets=ensured_targets
),
data_files=get_data_files(data_spec),
packages=find_packages(
exclude=[
"tests",
]
),
include_package_data=True,
zip_safe=False,
packages=find_packages(),
install_requires=requires,
test_suite="ipydagred3.tests",
tests_require=requires_test,
extras_require={
"dev": requires_dev,
"develop": requires_dev,
},
include_package_data=True,
zip_safe=False,
python_requires=">=3.7",
)

0 comments on commit a13bde4

Please sign in to comment.