Bundle generation fails with Cannot find namespace 'Protocol' (but Protocol doesn't seem to be a global declaration)

[d4h0]

Hi,

I'm trying to generate a .d.ts bundle for Playwright, but unfortunately I get the following error message:

packages/playwright-core/bundle.d.ts(11923,23): error TS2503: Cannot find namespace 'Protocol'.

I've read Fixing compilation issues while using declare module or similar "global" type declarations, and this doesn't seem to apply here (however, I haven't used TypeScript much, so I might be wrong).

Protocol seems to be defined in packages/playwright-core/types/protocol.d.ts:

export module Protocol {
    // ...
}

...which is imported in packages/playwright-core/types/types.d.ts via import { Protocol } from './protocol';, which itself is re-exported from packages/playwright-core/index.d.ts and packages/playwright/index.d.ts.

I've noticed two things:

1. packages/playwright-core/types/types.d.ts isn't in the src directory
2. The error says namespace 'Protocol', not module 'Protocol'.

Could any of this be the issue?

In any case, the generated file doesn't contain the module definition of Protocol.

Do you have any idea, why this isn't working?

The following commands reproduce the issue:

git clone https://github.com/microsoft/playwright/
cd playwright/
npm i -D dts-bundle-generator
npx dts-bundle-generator -o  packages/playwright-core/bundle.d.ts packages/playwright/index.d.ts

PS: In case you are wondering, I'm trying to generate a .d.ts bundle for Playwright to generate language bindings for F# via ts2fable, which unfortunately doesn't handle re-exports (so I'd like to use dts-bundle-generator to generate a .d.ts file that ts2fable understands).

[timocov]

The error says namespace 'Protocol', not module 'Protocol'.

This is what the compiler says. Internally "modules" are namespaces.

If you add --inline-declare-externals flag it seems to work fine. Meanwhile I'll look into why --inline-declare-externals affects such namespaces/modules.

[timocov]

It seems that the issue is caused by this code and changing this might be a breaking change. I'll assign the issue to the next major milestone, meanwhile please use workaround with --inline-declare-externals flag.

[timocov]

Note for the future fix: this requires to check how the new generation works for Dexie.js.

[d4h0]

Thanks, @timocov!

[timocov]

Released in v8.0.0.