Changed default behavior for module ModuleName statements (without quotes) and fixed wrong export state of referenced namespaces/modules
#242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quotes) and fixed wrong `export` state of references namespaces/modules Previously, for some reason name `ModuleName` was treated the same as with quotes i.e. it was checked whether that name should be exported. Now every used module with such name will be inlined regardless of `--inline-declare-externals` option. Fixes #237 Fixes #241
timocov
changed the title
module ModuleName statements (without quotes) and fixed wrong export state of references namespaces/modulesmodule ModuleName statements (without quotes) and fixed wrong export state of referenced namespaces/modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, for some reason name
ModuleNamewas treated the same as with quotes i.e. it was checked whether that name should be exported.Now every used module with such name will be inlined regardless of
--inline-declare-externalsoption.Fixes #237
Fixes #241